Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextServer, GDExtension] Fix building text servers as GDExtension, expose new/changed low-level methods to GDExtension API. #1479

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[TextServer, GDExtension] Fix building text servers as GDExtension, expose new/changed low-level methods to GDExtension API. #1479

merged 1 commit into from
Jun 13, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 3, 2024

@bruvzg bruvzg added enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation labels Jun 3, 2024
@bruvzg bruvzg added this to the 4.x milestone Jun 3, 2024
@bruvzg bruvzg mentioned this pull request Jun 3, 2024
Merged
@AThousandShips AThousandShips added the waiting for Godot This issue needs a Godot Engine improvement to be solved label Jun 3, 2024
@dsnopek
Copy link
Collaborator

dsnopek commented Jun 13, 2024

@bruvzg Now that the Godot PR is merged, could you please rebase this and take it out of draft? It also needs the updates to the gdextension_interface.h that were made later (adding @deprecated). Thanks!

@bruvzg
[TextServer, GDExtension] Fix building text servers as GDExtension, e…
2360f84 
…xpose new/changed low-level methods to GDExtension API.
@bruvzg bruvzg marked this pull request as ready for review June 13, 2024 16:20
@bruvzg bruvzg requested a review from a team as a code owner June 13, 2024 16:20
dsnopek
dsnopek approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@dsnopek dsnopek merged commit 9f6fe36 into godotengine:master Jun 13, 2024
12 checks passed
@aaronfranke
Copy link
Member

When I compile on the latest Godot master and the latest godot-cpp master on macOS, I get this error:

Compiling addons/secondext/src/godot-cpp/src/classes/low_level.cpp ...
addons/secondext/src/godot-cpp/src/classes/low_level.cpp:59:17: error: out-of-line definition of 'ptrw' does not match any declaration in 'godot::Image'
uint8_t *Image::ptrw() {
                ^~~~
addons/secondext/src/godot-cpp/src/classes/low_level.cpp:63:23: error: out-of-line definition of 'ptr' does not match any declaration in 'godot::Image'
const uint8_t *Image::ptr() {
                      ^~~
2 errors generated.
scons: *** [addons/secondext/src/godot-cpp/src/classes/low_level.macos.template_debug.universal.o] Error 1

@dsnopek
Copy link
Collaborator

dsnopek commented Jun 25, 2024

Does the generated image.hpp have the ptr() and ptrw() methods? It's sounds like maybe it didn't get re-generated after the update?

@aaronfranke
Copy link
Member

@dsnopek Apologies, it was a case of a bad cache / lack of regeneration. I tried nuking the generated files and compiling again and it worked.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation waiting for Godot This issue needs a Godot Engine improvement to be solved
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@bruvzg @dsnopek @aaronfranke @akien-mga @AThousandShips